Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply new deprecation decorators to pulse folder #9871

Merged
merged 6 commits into from
Mar 30, 2023

Conversation

Eric-Arellano
Copy link
Collaborator

Summary

See #9676 for the motivation.

Details and comments

@Eric-Arellano Eric-Arellano requested review from a team, eggerdj and wshanks as code owners March 29, 2023 15:01
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@Eric-Arellano Eric-Arellano added the Changelog: None Do not include in changelog label Mar 29, 2023
Copy link
Contributor

@nkanazawa1989 nkanazawa1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small typo but LGTM except for this.

qiskit/pulse/library/parametric_pulses.py Outdated Show resolved Hide resolved
@1ucian0 1ucian0 added the type: qa Issues and PRs that relate to testing and code quality label Mar 30, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4564031285

  • 18 of 18 (100.0%) changed or added relevant lines in 5 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 85.362%

Files with Coverage Reduction New Missed Lines %
qiskit/circuit/tools/pi_check.py 1 91.23%
qiskit/pulse/library/parametric_pulses.py 1 47.65%
qiskit/pulse/library/waveform.py 3 91.67%
Totals Coverage Status
Change from base Build 4564015162: -0.02%
Covered Lines: 67117
Relevant Lines: 78626

💛 - Coveralls

Copy link
Contributor

@nkanazawa1989 nkanazawa1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eric-Arellano Eric-Arellano added this pull request to the merge queue Mar 30, 2023
Merged via the queue into Qiskit:main with commit c4f1d2d Mar 30, 2023
@Eric-Arellano Eric-Arellano deleted the apply-deprecations-pulse branch March 30, 2023 15:14
ElePT pushed a commit to ElePT/qiskit that referenced this pull request Apr 5, 2023
* Apply new deprecation decorators to pulse folder

* Update qiskit/pulse/library/parametric_pulses.py

Co-authored-by: Naoki Kanazawa <[email protected]>

* Fix bad use of DeMorgan's law for boolean

---------

Co-authored-by: Naoki Kanazawa <[email protected]>
giacomoRanieri pushed a commit to giacomoRanieri/qiskit-terra that referenced this pull request Apr 16, 2023
* Apply new deprecation decorators to pulse folder

* Update qiskit/pulse/library/parametric_pulses.py

Co-authored-by: Naoki Kanazawa <[email protected]>

* Fix bad use of DeMorgan's law for boolean

---------

Co-authored-by: Naoki Kanazawa <[email protected]>
king-p3nguin pushed a commit to king-p3nguin/qiskit-terra that referenced this pull request May 22, 2023
* Apply new deprecation decorators to pulse folder

* Update qiskit/pulse/library/parametric_pulses.py

Co-authored-by: Naoki Kanazawa <[email protected]>

* Fix bad use of DeMorgan's law for boolean

---------

Co-authored-by: Naoki Kanazawa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants